Back
From: metabase:user:1eed3a18-483e-11e2-a87b-a3931c712682
Subject: FAIL libnet-1.30 v5.8.9 Mac OS X
Date: 2014-10-08T11:19:27Z
This distribution has been tested as part of the CPAN Testers
project, supporting the Perl programming language. See
http://wiki.cpantesters.org/ for more information or email
questions to cpan-testers-discuss@perl.org
--
Dear SHAY,
This is a computer-generated report for libnet-1.30
on perl 5.8.9, created by App::cpanminus::reporter 0.11 (1.7001).
Thank you for uploading your work to CPAN. However, there was a problem
testing your distribution.
If you think this report is invalid, please consult the CPAN Testers Wiki
for suggestions on how to avoid getting FAIL reports for missing library
or binary dependencies, unsupported operating systems, and so on:
http://wiki.cpantesters.org/wiki/CPANAuthorNotes
Sections of this report:
* Tester comments
* Program output
* Prerequisites
* Environment and other context
------------------------------
TESTER COMMENTS
------------------------------
Additional comments from tester:
none provided
------------------------------
PROGRAM OUTPUT
------------------------------
Output from '':
Building and testing libnet-1.30
cp lib/Net/NNTP.pm blib/lib/Net/NNTP.pm
cp lib/Net/Time.pm blib/lib/Net/Time.pm
cp lib/Net/Netrc.pm blib/lib/Net/Netrc.pm
cp lib/Net/FTP/dataconn.pm blib/lib/Net/FTP/dataconn.pm
cp lib/Net/FTP/I.pm blib/lib/Net/FTP/I.pm
cp lib/Net/libnetFAQ.pod blib/lib/Net/libnetFAQ.pod
cp lib/Net/FTP/L.pm blib/lib/Net/FTP/L.pm
cp lib/Net/Domain.pm blib/lib/Net/Domain.pm
cp lib/Net/FTP.pm blib/lib/Net/FTP.pm
cp lib/Net/FTP/A.pm blib/lib/Net/FTP/A.pm
cp lib/Net/SMTP.pm blib/lib/Net/SMTP.pm
cp lib/Net/FTP/E.pm blib/lib/Net/FTP/E.pm
cp lib/Net/Config.pm blib/lib/Net/Config.pm
cp libnet.cfg blib/lib/Net/libnet.cfg
cp lib/Net/Cmd.pm blib/lib/Net/Cmd.pm
cp lib/Net/POP3.pm blib/lib/Net/POP3.pm
Manifying blib/man3/Net::Cmd.3
Manifying blib/man3/Net::Config.3
Manifying blib/man3/Net::Domain.3
Manifying blib/man3/Net::FTP.3
Manifying blib/man3/Net::FTP::dataconn.3
Manifying blib/man3/Net::NNTP.3
Manifying blib/man3/Net::Netrc.3
Manifying blib/man3/Net::POP3.3
Manifying blib/man3/Net::SMTP.3
Manifying blib/man3/Net::Time.3
Manifying blib/man3/Net::libnetFAQ.3
PERL_DL_NONLAZY=1 /Users/stas/perl5/perlbrew/perls/perl-5.8.9/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/config.t ........ ok
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "./Configure"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "./Configure":
# Main code has high complexity score (40) at line 1, column 1. Consider refactoring. (Severity: 3)
# Package variable declared or used at line 16, column 1. See pages 73,75 of PBP. (Severity: 3)
# Subroutine "valid_host" does not end with "return" at line 31, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "test_hostnames" does not end with "return" at line 42, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "Prompt" does not end with "return" at line 66, column 1. See page 197 of PBP. (Severity: 4)
# Reused variable name in lexical scope: $def at line 68, column 2. Invent unique variable names. (Severity: 3)
# Subroutine "get_host_list" does not end with "return" at line 86, column 1. See page 197 of PBP. (Severity: 4)
# Reused variable name in lexical scope: $def at line 88, column 2. Invent unique variable names. (Severity: 3)
# Reused variable name in lexical scope: $ans at line 96, column 4. Invent unique variable names. (Severity: 3)
# Regular expression without "/x" flag at line 98, column 12. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 100, column 19. See page 236 of PBP. (Severity: 3)
# Subroutine "get_hostname" does not end with "return" at line 111, column 1. See page 197 of PBP. (Severity: 4)
# Reused variable name in lexical scope: $def at line 113, column 2. Invent unique variable names. (Severity: 3)
# Reused variable name in lexical scope: $ans at line 119, column 4. Invent unique variable names. (Severity: 3)
# Regular expression without "/x" flag at line 120, column 21. See page 236 of PBP. (Severity: 3)
# Subroutine "get_bool" does not end with "return" at line 145, column 1. See page 197 of PBP. (Severity: 4)
# Reused variable name in lexical scope: $def at line 147, column 2. Invent unique variable names. (Severity: 3)
# Regular expression without "/x" flag at line 153, column 10. See page 236 of PBP. (Severity: 3)
# Subroutine "get_netmask" does not end with "return" at line 160, column 1. See page 197 of PBP. (Severity: 4)
# Reused variable name in lexical scope: $def at line 162, column 2. Invent unique variable names. (Severity: 3)
# Reused variable name in lexical scope: $ans at line 172, column 4. Invent unique variable names. (Severity: 3)
# Regular expression without "/x" flag at line 184, column 20. See page 236 of PBP. (Severity: 3)
# Capture variable used outside conditional at line 189, column 29. See page 253 of PBP. (Severity: 3)
# Capture variable used outside conditional at line 189, column 32. See page 253 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 189, column 41. See page 236 of PBP. (Severity: 3)
# Capture variable used outside conditional at line 189, column 47. See page 253 of PBP. (Severity: 3)
# Always unpack @_ first at line 219, column 1. See page 178 of PBP. (Severity: 4)
# Warnings disabled at line 248, column 1. See page 431 of PBP. (Severity: 4)
# Warnings disabled at line 259, column 3. See page 431 of PBP. (Severity: 4)
# Package variable declared or used at line 260, column 13. See pages 73,75 of PBP. (Severity: 3)
# Map blocks should have a single statement at line 264, column 1. See page 113 of PBP. (Severity: 3)
# "map" used in void context at line 264, column 1. Use a "for" loop instead. (Severity: 3)
# Regular expression without "/x" flag at line 264, column 50. See page 236 of PBP. (Severity: 3)
# Heredoc terminator must be quoted at line 273, column 10. See page 64 of PBP. (Severity: 3)
# Heredoc terminator must be quoted at line 286, column 8. See page 64 of PBP. (Severity: 3)
# Heredoc terminator must be quoted at line 301, column 7. See page 64 of PBP. (Severity: 3)
# Heredoc terminator must be quoted at line 314, column 7. See page 64 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 335, column 34. See page 236 of PBP. (Severity: 3)
# Heredoc terminator must be quoted at line 382, column 8. See page 64 of PBP. (Severity: 3)
# Heredoc terminator must be quoted at line 453, column 9. See page 64 of PBP. (Severity: 3)
# Literal line breaks in a string at line 472, column 7. See pages 60,61 of PBP. (Severity: 3)
# Heredoc terminator must be quoted at line 502, column 7. See page 64 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 537, column 32. See page 236 of PBP. (Severity: 3)
# Heredoc terminator must be quoted at line 541, column 8. See page 64 of PBP. (Severity: 3)
# Heredoc terminator must be quoted at line 557, column 8. See page 64 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 574, column 9. See page 283 of PBP. (Severity: 3)
# Map blocks should have a single statement at line 587, column 13. See page 113 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 590, column 34. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 597, column 17. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 598, column 44. See page 236 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "./Makefile.PL"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "./Makefile.PL":
# Package variable declared or used at line 34, column 1. See pages 73,75 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 59, column 43. See page 236 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "demos/ftp"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "demos/ftp":
# Package variable declared or used at line 12, column 1. See pages 73,75 of PBP. (Severity: 3)
# Package variable declared or used at line 13, column 1. See pages 73,75 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "demos/nntp"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "demos/nntp":
# Package variable declared or used at line 12, column 1. See pages 73,75 of PBP. (Severity: 3)
# "warn" used instead of "carp" at line 27, column 3. See page 283 of PBP. (Severity: 3)
# "warn" used instead of "carp" at line 39, column 5. See page 283 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "demos/nntp.mirror"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "demos/nntp.mirror":
# Regular expression without "/x" flag at line 52, column 43. See page 236 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "demos/smtp.self"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "demos/smtp.self":
# "map" used in void context at line 68, column 3. Use a "for" loop instead. (Severity: 3)
# Regular expression without "/x" flag at line 68, column 9. See page 236 of PBP. (Severity: 3)
# "warn" used instead of "carp" at line 75, column 3. See page 283 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/config.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/config.t":
# Magic variable "$INC" should be assigned as "local" at line 17, column 23. See pages 81,82 of PBP. (Severity: 4)
# Subroutine "import" does not end with "return" at line 22, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "set_fail" does not end with "return" at line 32, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 36, column 1. See page 178 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 38, column 48. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 43, column 1. See page 178 of PBP. (Severity: 4)
# Multiple "package" declarations at line 48, column 1. Limit to one per file. (Severity: 4)
# Regular expression without "/x" flag at line 51, column 30. See page 236 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/datasend.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/datasend.t":
# @ISA used instead of "use base" at line 22, column 7. See page 360 of PBP. (Severity: 3)
# Subroutine "timeout" does not end with "return" at line 24, column 3. See page 197 of PBP. (Severity: 4)
# Subroutine "new" does not end with "return" at line 26, column 3. See page 197 of PBP. (Severity: 4)
# Subroutine "output" does not end with "return" at line 32, column 3. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 44, column 30. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 45, column 22. See page 283 of PBP. (Severity: 3)
# Always unpack @_ first at line 49, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "check" does not end with "return" at line 49, column 1. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/libnet_t.pl"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/libnet_t.pl":
# Code not contained in explicit package at line 1, column 1. Violates encapsulation. (Severity: 4)
# Subroutine "is" does not end with "return" at line 17, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "skip" does not end with "return" at line 29, column 1. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/netrc.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/netrc.t":
# Magic variable "$ENV" should be assigned as "local" at line 21, column 12. See pages 81,82 of PBP. (Severity: 4)
# "local" variable not initialized at line 24, column 1. See page 78 of PBP. (Severity: 3)
# Magic variable "$INC" should be assigned as "local" at line 37, column 23. See pages 81,82 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 39, column 30. See page 236 of PBP. (Severity: 3)
# Return value of eval not tested at line 43, column 1. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
# Comma used to separate statements at line 49, column 9. See pages 68,71 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 50, column 27. See page 236 of PBP. (Severity: 3)
# Private subroutine/method used at line 59, column 34. Use published APIs. (Severity: 3)
# Regular expression without "/x" flag at line 61, column 29. See page 236 of PBP. (Severity: 3)
# Private subroutine/method used at line 68, column 36. Use published APIs. (Severity: 3)
# Regular expression without "/x" flag at line 70, column 31. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 81, column 29. See page 236 of PBP. (Severity: 3)
# Heredoc terminator must be quoted at line 81, column 35. See page 64 of PBP. (Severity: 3)
# Private subroutine/method used at line 95, column 17. Use published APIs. (Severity: 3)
# Always unpack @_ first at line 135, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "new" does not end with "return" at line 135, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 140, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "TIEHANDLE" does not end with "return" at line 140, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "set_lines" does not end with "return" at line 146, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "READLINE" does not end with "return" at line 150, column 1. See page 197 of PBP. (Severity: 4)
# Ambiguously named subroutine "close" at line 154, column 1. See page 48 of PBP. (Severity: 3)
# Subroutine name is a homonym for builtin function close at line 154, column 1. See page 177 of PBP. (Severity: 4)
# Subroutine "close" does not end with "return" at line 154, column 1. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/nntp.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/nntp.t":
# "map" used in void context at line 43, column 5. Use a "for" loop instead. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/nntp_ipv6.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/nntp_ipv6.t":
# Regular expression without "/x" flag at line 18, column 19. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 31, column 31. See page 283 of PBP. (Severity: 3)
# Subroutine "nntp_server" does not end with "return" at line 44, column 1. See page 197 of PBP. (Severity: 4)
# Reused variable name in lexical scope: $cl at line 46, column 3. Invent unique variable names. (Severity: 3)
# "die" used instead of "croak" at line 46, column 28. See page 283 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 49, column 22. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 49, column 50. See page 283 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/nntp_ssl.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/nntp_ssl.t":
# Package variable declared or used at line 20, column 10. See pages 73,75 of PBP. (Severity: 3)
# Package variable declared or used at line 20, column 37. See pages 73,75 of PBP. (Severity: 3)
# Package variable declared or used at line 22, column 6. See pages 73,75 of PBP. (Severity: 3)
# Package variable declared or used at line 23, column 6. See pages 73,75 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 23, column 34. See page 236 of PBP. (Severity: 3)
# Subroutine "test" does not end with "return" at line 56, column 1. See page 197 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 58, column 33. See page 283 of PBP. (Severity: 3)
# Subroutine "nntp_client" does not end with "return" at line 65, column 1. See page 197 of PBP. (Severity: 4)
# Warnings disabled at line 85, column 5. See page 431 of PBP. (Severity: 4)
# Subroutine "nntp_server" does not end with "return" at line 93, column 1. See page 197 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 95, column 28. See page 283 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 110, column 22. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 110, column 50. See page 283 of PBP. (Severity: 3)
# Mixed high and low-precedence booleans at line 117, column 15. See page 70 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/pop3_ipv6.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/pop3_ipv6.t":
# Regular expression without "/x" flag at line 18, column 19. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 30, column 31. See page 283 of PBP. (Severity: 3)
# Subroutine "pop3_server" does not end with "return" at line 43, column 1. See page 197 of PBP. (Severity: 4)
# Reused variable name in lexical scope: $cl at line 44, column 3. Invent unique variable names. (Severity: 3)
# "die" used instead of "croak" at line 44, column 28. See page 283 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 47, column 22. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 47, column 50. See page 283 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/pop3_ssl.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/pop3_ssl.t":
# Package variable declared or used at line 20, column 10. See pages 73,75 of PBP. (Severity: 3)
# Package variable declared or used at line 20, column 37. See pages 73,75 of PBP. (Severity: 3)
# Package variable declared or used at line 22, column 6. See pages 73,75 of PBP. (Severity: 3)
# Package variable declared or used at line 23, column 6. See pages 73,75 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 23, column 34. See page 236 of PBP. (Severity: 3)
# Subroutine "test" does not end with "return" at line 59, column 1. See page 197 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 61, column 33. See page 283 of PBP. (Severity: 3)
# Subroutine "pop3_client" does not end with "return" at line 68, column 1. See page 197 of PBP. (Severity: 4)
# Warnings disabled at line 83, column 5. See page 431 of PBP. (Severity: 4)
# Subroutine "pop3_server" does not end with "return" at line 91, column 1. See page 197 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 93, column 28. See page 283 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 108, column 22. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 108, column 50. See page 283 of PBP. (Severity: 3)
# Mixed high and low-precedence booleans at line 117, column 15. See page 70 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/smtp_ipv6.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/smtp_ipv6.t":
# Regular expression without "/x" flag at line 18, column 19. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 30, column 31. See page 283 of PBP. (Severity: 3)
# Subroutine "smtp_server" does not end with "return" at line 43, column 1. See page 197 of PBP. (Severity: 4)
# Reused variable name in lexical scope: $cl at line 44, column 3. Invent unique variable names. (Severity: 3)
# "die" used instead of "croak" at line 44, column 28. See page 283 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 47, column 22. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 47, column 50. See page 283 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/smtp_ssl.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/smtp_ssl.t":
# Package variable declared or used at line 20, column 10. See pages 73,75 of PBP. (Severity: 3)
# Package variable declared or used at line 20, column 37. See pages 73,75 of PBP. (Severity: 3)
# Package variable declared or used at line 22, column 6. See pages 73,75 of PBP. (Severity: 3)
# Package variable declared or used at line 23, column 6. See pages 73,75 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 23, column 34. See page 236 of PBP. (Severity: 3)
# Subroutine "test" does not end with "return" at line 59, column 1. See page 197 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 61, column 33. See page 283 of PBP. (Severity: 3)
# Subroutine "smtp_client" does not end with "return" at line 68, column 1. See page 197 of PBP. (Severity: 4)
# Warnings disabled at line 83, column 5. See page 431 of PBP. (Severity: 4)
# Subroutine "smtp_server" does not end with "return" at line 91, column 1. See page 197 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 93, column 28. See page 283 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 108, column 22. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 108, column 50. See page 283 of PBP. (Severity: 3)
# Cascading if-elsif chain at line 110, column 5. See pages 117,118 of PBP. (Severity: 3)
# Mixed high and low-precedence booleans at line 119, column 15. See page 70 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/time.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/time.t":
# Magic variable "$INC" should be assigned as "local" at line 15, column 26. See pages 81,82 of PBP. (Severity: 4)
# Magic variable "$INC" should be assigned as "local" at line 16, column 26. See pages 81,82 of PBP. (Severity: 4)
# Magic variable "$INC" should be assigned as "local" at line 17, column 31. See pages 81,82 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 20, column 30. See page 236 of PBP. (Severity: 3)
# Return value of eval not tested at line 25, column 1. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
# Private subroutine/method used at line 31, column 15. Use published APIs. (Severity: 3)
# Private subroutine/method used at line 35, column 12. Use published APIs. (Severity: 3)
# Private subroutine/method used at line 41, column 9. Use published APIs. (Severity: 3)
# Subroutine "make_fail" does not end with "return" at line 66, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 80, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "new" does not end with "return" at line 80, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine name is a homonym for builtin function send at line 86, column 1. See page 177 of PBP. (Severity: 4)
# Subroutine "send" does not end with "return" at line 86, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 94, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "set_message" does not end with "return" at line 94, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 102, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "do_recv" does not end with "return" at line 102, column 1. See page 197 of PBP. (Severity: 4)
# Reused variable name in lexical scope: $msg at line 103, column 9. Invent unique variable names. (Severity: 3)
# Subroutine name is a homonym for builtin function recv at line 107, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 107, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "recv" does not end with "return" at line 107, column 1. See page 197 of PBP. (Severity: 4)
# Multiple "package" declarations at line 118, column 1. Limit to one per file. (Severity: 4)
# Subroutine "new" does not end with "return" at line 120, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "can_read" does not end with "return" at line 126, column 1. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/Cmd.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/Cmd.pm":
# Regular expression without "/x" flag at line 40, column 31. See page 236 of PBP. (Severity: 3)
# @ISA used instead of "use base" at line 45, column 5. See page 360 of PBP. (Severity: 3)
# Symbols are exported by default at line 46, column 1. Use '@EXPORT_OK' or '%EXPORT_TAGS' instead. (Severity: 4)
# Pragma "constant" used at line 48, column 1. See page 55 of PBP. (Severity: 4)
# Pragma "constant" used at line 49, column 1. See page 55 of PBP. (Severity: 4)
# Pragma "constant" used at line 50, column 1. See page 55 of PBP. (Severity: 4)
# Pragma "constant" used at line 51, column 1. See page 55 of PBP. (Severity: 4)
# Pragma "constant" used at line 52, column 1. See page 55 of PBP. (Severity: 4)
# Pragma "constant" used at line 53, column 1. See page 55 of PBP. (Severity: 4)
# Pragma "constant" used at line 55, column 1. See page 55 of PBP. (Severity: 4)
# Always unpack @_ first at line 61, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "toebcdic" does not end with "return" at line 61, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 67, column 48. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 67, column 72. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 76, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "toascii" does not end with "return" at line 76, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_print_isa" does not end with "return" at line 84, column 1. See page 197 of PBP. (Severity: 4)
# Don't turn off strict for large blocks of code at line 85, column 3. See page 433 of PBP. (Severity: 4)
# Always unpack @_ first at line 117, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "debug" does not end with "return" at line 117, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "message" does not end with "return" at line 151, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 162, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "debug_text" does not end with "return" at line 162, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "debug_print" does not end with "return" at line 165, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "code" does not end with "return" at line 171, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "status" does not end with "return" at line 183, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 192, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "set_status" does not end with "return" at line 192, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_set_status_timeout" does not end with "return" at line 208, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_set_status_closed" does not end with "return" at line 216, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 234, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "command" does not end with "return" at line 234, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 249, column 9. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 274, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "ok" does not end with "return" at line 274, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "unsupported" does not end with "return" at line 282, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "getline" does not end with "return" at line 291, column 1. See page 197 of PBP. (Severity: 4)
# Lvalue form of "substr" used at line 322, column 26. See page 165 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 324, column 23. See page 236 of PBP. (Severity: 3)
# Subroutine "ungetline" does not end with "return" at line 349, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 357, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "parse_response" does not end with "return" at line 357, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 359, column 21. See page 236 of PBP. (Severity: 3)
# Subroutine "response" does not end with "return" at line 364, column 1. See page 197 of PBP. (Severity: 4)
# Magic variable "$@" should be assigned as "local" at line 383, column 10. See pages 81,82 of PBP. (Severity: 4)
# Subroutine "read_until_dot" does not end with "return" at line 399, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 410, column 22. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 412, column 13. See page 236 of PBP. (Severity: 3)
# Subroutine "datasend" with high complexity score (23) at line 426, column 1. Consider refactoring. (Severity: 3)
# Always unpack @_ first at line 426, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "datasend" does not end with "return" at line 426, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 446, column 26. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 459, column 36. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 463, column 33. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 466, column 12. See page 236 of PBP. (Severity: 3)
# Lvalue form of "substr" used at line 468, column 23. See page 165 of PBP. (Severity: 3)
# Always unpack @_ first at line 504, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "rawdatasend" does not end with "return" at line 504, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 517, column 41. See page 236 of PBP. (Severity: 3)
# Subroutine "dataend" does not end with "return" at line 549, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 604, column 1. See page 178 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 609, column 10. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 611, column 47. See page 236 of PBP. (Severity: 3)
# Lvalue form of "substr" used at line 615, column 30. See page 165 of PBP. (Severity: 3)
# Lvalue form of "substr" used at line 616, column 48. See page 165 of PBP. (Severity: 3)
# Subroutine "READLINE" does not end with "return" at line 623, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 630, column 22. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 635, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "CLOSE" does not end with "return" at line 646, column 1. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/Config.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/Config.pm":
# Symbols are exported by default at line 20, column 1. Use '@EXPORT_OK' or '%EXPORT_TAGS' instead. (Severity: 4)
# @ISA used instead of "use base" at line 21, column 5. See page 360 of PBP. (Severity: 3)
# Return value of eval not tested at line 26, column 1. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
# "local" variable not initialized at line 26, column 8. See page 78 of PBP. (Severity: 3)
# Package variable declared or used at line 28, column 1. See pages 73,75 of PBP. (Severity: 3)
# Return value of eval not tested at line 49, column 20. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
# Heredoc terminator must be quoted at line 49, column 25. See page 64 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 73, column 10. See page 236 of PBP. (Severity: 3)
# "local" variable not initialized at line 75, column 17. See page 78 of PBP. (Severity: 3)
# Mixed high and low-precedence booleans at line 81, column 5. See page 70 of PBP. (Severity: 4)
# "local" variable not initialized at line 82, column 21. See page 78 of PBP. (Severity: 3)
# "local" variable not initialized at line 86, column 25. See page 78 of PBP. (Severity: 3)
# Mixed high and low-precedence booleans at line 94, column 9. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 94, column 15. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 110, column 45. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 114, column 27. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 116, column 47. See page 236 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/Domain.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/Domain.pm":
# @ISA used instead of "use base" at line 21, column 5. See page 360 of PBP. (Severity: 3)
# Subroutine "_hostname" with high complexity score (22) at line 30, column 1. Consider refactoring. (Severity: 3)
# Subroutine "_hostname" does not end with "return" at line 30, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 46, column 35. See page 236 of PBP. (Severity: 3)
# Backtick operator used at line 51, column 19. Use IPC::Open3 instead. (Severity: 3)
# Regular expression without "/x" flag at line 58, column 35. See page 236 of PBP. (Severity: 3)
# "local" variable not initialized at line 63, column 5. See page 78 of PBP. (Severity: 3)
# Mixed high and low-precedence booleans at line 68, column 7. See page 70 of PBP. (Severity: 4)
# Multiple "package" declarations at line 69, column 9. Limit to one per file. (Severity: 4)
# Multiple "package" declarations at line 74, column 9. Limit to one per file. (Severity: 4)
# Backtick operator used at line 92, column 20. Use IPC::Open3 instead. (Severity: 3)
# Backtick operator used at line 97, column 20. Use IPC::Open3 instead. (Severity: 3)
# Regular expression without "/x" flag at line 101, column 32. See page 236 of PBP. (Severity: 3)
# Backtick operator used at line 101, column 42. Use IPC::Open3 instead. (Severity: 3)
# Return value of eval not tested at line 103, column 10. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
# Regular expression without "/x" flag at line 107, column 12. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 108, column 12. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 109, column 12. See page 236 of PBP. (Severity: 3)
# Subroutine "_hostdomain" with high complexity score (27) at line 115, column 1. Consider refactoring. (Severity: 3)
# Subroutine "_hostdomain" does not end with "return" at line 115, column 1. See page 197 of PBP. (Severity: 4)
# "local" variable not initialized at line 121, column 3. See page 78 of PBP. (Severity: 3)
# "local" variable not initialized at line 131, column 3. See page 78 of PBP. (Severity: 3)
# Only use a capturing group if you plan to use the captured value at line 136, column 13. See page 252 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 136, column 13. See page 236 of PBP. (Severity: 3)
# Reused variable name in lexical scope: $host at line 146, column 3. Invent unique variable names. (Severity: 3)
# Regular expression without "/x" flag at line 151, column 38. See page 236 of PBP. (Severity: 3)
# Return value of eval not tested at line 153, column 5. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
# Mixed high and low-precedence booleans at line 155, column 7. See page 70 of PBP. (Severity: 4)
# Multiple "package" declarations at line 156, column 9. Limit to one per file. (Severity: 4)
# Multiple "package" declarations at line 160, column 9. Limit to one per file. (Severity: 4)
# Backtick operator used at line 174, column 17. Use IPC::Open3 instead. (Severity: 3)
# Regular expression without "/x" flag at line 175, column 38. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 179, column 15. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 182, column 17. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 201, column 30. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 212, column 16. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 213, column 16. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 214, column 16. See page 236 of PBP. (Severity: 3)
# Subroutine "domainname" does not end with "return" at line 221, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 230, column 34. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 244, column 18. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 245, column 20. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 248, column 54. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 250, column 40. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 251, column 40. See page 236 of PBP. (Severity: 3)
# Subroutine "hostfqdn" does not end with "return" at line 290, column 1. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/FTP.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/FTP.pm":
# Subroutine "can_ssl" does not end with "return" at line 50, column 3. See page 197 of PBP. (Severity: 4)
# Subroutine "can_inet6" does not end with "return" at line 51, column 3. See page 197 of PBP. (Severity: 4)
# @ISA used instead of "use base" at line 56, column 5. See page 360 of PBP. (Severity: 3)
# Pragma "constant" used at line 58, column 1. See page 55 of PBP. (Severity: 4)
# Pragma "constant" used at line 59, column 1. See page 55 of PBP. (Severity: 4)
# Pragma "constant" used at line 60, column 1. See page 55 of PBP. (Severity: 4)
# Pragma "constant" used at line 62, column 1. See page 55 of PBP. (Severity: 4)
# Subroutine "new" with high complexity score (32) at line 64, column 1. Consider refactoring. (Severity: 3)
# Always unpack @_ first at line 64, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "new" does not end with "return" at line 64, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 99, column 30. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 107, column 40. See page 236 of PBP. (Severity: 3)
# Magic variable "$@" should be assigned as "local" at line 155, column 8. See pages 81,82 of PBP. (Severity: 4)
# Subroutine "host" does not end with "return" at line 167, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "passive" does not end with "return" at line 172, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 179, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "hash" does not end with "return" at line 179, column 1. See page 197 of PBP. (Severity: 4)
# Magic variable "$b" should be assigned as "local" at line 187, column 12. See pages 81,82 of PBP. (Severity: 4)
# One-argument "select" used at line 188, column 3. See page 224 of PBP. (Severity: 4)
# One-argument "select" used at line 188, column 11. See page 224 of PBP. (Severity: 4)
# Magic variable "$|" should be assigned as "local" at line 188, column 26. See pages 81,82 of PBP. (Severity: 4)
# Magic variable "$b" should be assigned as "local" at line 189, column 6. See pages 81,82 of PBP. (Severity: 4)
# Subroutine "quit" does not end with "return" at line 194, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 205, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "ascii" does not end with "return" at line 205, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 206, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "binary" does not end with "return" at line 206, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 209, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "ebcdic" does not end with "return" at line 209, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 215, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "byte" does not end with "return" at line 215, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 223, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "quot" does not end with "return" at line 223, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 232, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "site" does not end with "return" at line 232, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "mdtm" does not end with "return" at line 240, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 253, column 25. See page 236 of PBP. (Severity: 3)
# Subroutine "size" does not end with "return" at line 259, column 1. See page 197 of PBP. (Severity: 4)
# "$io" is declared but not used at line 262, column 3. Unused variables clutter code and make it harder to read. (Severity: 3)
# Regular expression without "/x" flag at line 265, column 27. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 273, column 21. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 274, column 21. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 280, column 21. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 281, column 25. See page 236 of PBP. (Severity: 3)
# Subroutine "login" with high complexity score (43) at line 317, column 1. Consider refactoring. (Severity: 3)
# Subroutine "login" does not end with "return" at line 317, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 387, column 56. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 399, column 62. See page 236 of PBP. (Severity: 3)
# Subroutine "account" does not end with "return" at line 417, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_auth_id" does not end with "return" at line 425, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "authorize" does not end with "return" at line 443, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 444, column 3. See page 70 of PBP. (Severity: 4)
# Subroutine name is a homonym for builtin function rename at line 457, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 457, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "rename" does not end with "return" at line 457, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 467, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "type" does not end with "return" at line 467, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 484, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "alloc" does not end with "return" at line 484, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "abort" does not end with "return" at line 501, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "get" with high complexity score (25) at line 517, column 1. Consider refactoring. (Severity: 3)
# "local" variable not initialized at line 521, column 3. See page 78 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 525, column 25. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 529, column 19. See page 236 of PBP. (Severity: 3)
# "local" variable not initialized at line 567, column 3. See page 78 of PBP. (Severity: 3)
# Always unpack @_ first at line 610, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "cwd" does not end with "return" at line 610, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 611, column 3. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 615, column 46. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 623, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "cdup" does not end with "return" at line 623, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "pwd" does not end with "return" at line 629, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine name is a homonym for builtin function rmdir at line 647, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 647, column 1. See page 178 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 648, column 3. See page 70 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 654, column 3. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 660, column 26. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 669, column 27. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 689, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine name is a homonym for builtin function mkdir at line 700, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 700, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "mkdir" does not end with "return" at line 700, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 701, column 3. See page 70 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 705, column 3. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 711, column 22. See page 236 of PBP. (Severity: 3)
# Subroutine name is a homonym for builtin function delete at line 745, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 745, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "delete" does not end with "return" at line 745, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 752, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "put" does not end with "return" at line 752, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 753, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "put_unique" does not end with "return" at line 753, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 754, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "append" does not end with "return" at line 754, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 757, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "nlst" does not end with "return" at line 757, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 758, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "list" does not end with "return" at line 758, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 759, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "retr" does not end with "return" at line 759, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 760, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "stor" does not end with "return" at line 760, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 761, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "stou" does not end with "return" at line 761, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 762, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "appe" does not end with "return" at line 762, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_store_cmd" with high complexity score (33) at line 765, column 1. Consider refactoring. (Severity: 3)
# "local" variable not initialized at line 768, column 3. See page 78 of PBP. (Severity: 3)
# Mixed high and low-precedence booleans at line 772, column 7. See page 70 of PBP. (Severity: 4)
# "local" variable not initialized at line 788, column 21. See page 78 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 792, column 40. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 817, column 31. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 859, column 46. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 868, column 1. See page 178 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 869, column 5. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 873, column 1. See page 178 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 874, column 3. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 898, column 30. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 907, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "ls" does not end with "return" at line 907, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 908, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "dir" does not end with "return" at line 908, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 918, column 22. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 920, column 23. See page 236 of PBP. (Severity: 3)
# Subroutine "epsv" does not end with "return" at line 926, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 931, column 35. See page 236 of PBP. (Severity: 3)
# Subroutine "unique_name" does not end with "return" at line 937, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "supported" does not end with "return" at line 943, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 959, column 16. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 960, column 14. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 961, column 21. See page 236 of PBP. (Severity: 3)
# Subroutine "_extract_path" does not end with "return" at line 996, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 1004, column 25. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 1005, column 24. See page 236 of PBP. (Severity: 3)
# Return value of eval not tested at line 1018, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
# Always unpack @_ first at line 1064, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_list_cmd" does not end with "return" at line 1064, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 1087, column 21. See page 236 of PBP. (Severity: 3)
# Subroutine "_data_cmd" with high complexity score (28) at line 1101, column 1. Consider refactoring. (Severity: 3)
# Always unpack @_ first at line 1101, column 1. See page 178 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 1110, column 18. See page 236 of PBP. (Severity: 3)
# Mixed high and low-precedence booleans at line 1119, column 9. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 1133, column 22. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 1151, column 15. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 1172, column 27. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 1188, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "debug_text" does not end with "return" at line 1188, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 1188, column 27. See page 236 of PBP. (Severity: 3)
# Subroutine "command" does not end with "return" at line 1191, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "response" does not end with "return" at line 1199, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1210, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "parse_response" does not end with "return" at line 1210, column 1. See page 197 of PBP. (Severity: 4)
# Capture variable used outside conditional at line 1211, column 11. See page 253 of PBP. (Severity: 3)
# Capture variable used outside conditional at line 1211, column 15. See page 253 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 1212, column 17. See page 236 of PBP. (Severity: 3)
# Subroutine "pasv_xfer_unique" does not end with "return" at line 1229, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "pasv_xfer" does not end with "return" at line 1235, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 1238, column 24. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 1261, column 1. See page 178 of PBP. (Severity: 4)
# Capture variable used outside conditional at line 1279, column 10. See page 253 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 1280, column 25. See page 236 of PBP. (Severity: 3)
# Capture variable used outside conditional at line 1282, column 10. See page 253 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 1283, column 30. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 1289, column 1. See page 178 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 1303, column 19. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 1309, column 17. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 1313, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "cmd" does not end with "return" at line 1313, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_ABOR' declared but not used at line 1321, column 1. Eliminate dead code. (Severity: 3)
# Subroutine "_ABOR" does not end with "return" at line 1321, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1322, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_ALLO" does not end with "return" at line 1322, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_CDUP" does not end with "return" at line 1323, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_NOOP' declared but not used at line 1324, column 1. Eliminate dead code. (Severity: 3)
# Subroutine "_NOOP" does not end with "return" at line 1324, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_PASV" does not end with "return" at line 1325, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_QUIT" does not end with "return" at line 1326, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1327, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_DELE" does not end with "return" at line 1327, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1328, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_CWD" does not end with "return" at line 1328, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1329, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_PORT" does not end with "return" at line 1329, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1330, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_RMD" does not end with "return" at line 1330, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1331, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_MKD" does not end with "return" at line 1331, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1332, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_PWD" does not end with "return" at line 1332, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1333, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_TYPE" does not end with "return" at line 1333, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1334, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_RNTO" does not end with "return" at line 1334, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1335, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_RESP" does not end with "return" at line 1335, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1336, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_MDTM" does not end with "return" at line 1336, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1337, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_SIZE" does not end with "return" at line 1337, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1338, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_HELP" does not end with "return" at line 1338, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1339, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_STAT" does not end with "return" at line 1339, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1340, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_FEAT" does not end with "return" at line 1340, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1341, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_PBSZ" does not end with "return" at line 1341, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1342, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_PROT" does not end with "return" at line 1342, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1343, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_CCC" does not end with "return" at line 1343, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1344, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_EPRT" does not end with "return" at line 1344, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1345, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_EPSV" does not end with "return" at line 1345, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_APPE' declared but not used at line 1346, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1346, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_APPE" does not end with "return" at line 1346, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_LIST' declared but not used at line 1347, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1347, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_LIST" does not end with "return" at line 1347, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_NLST' declared but not used at line 1348, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1348, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_NLST" does not end with "return" at line 1348, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_RETR' declared but not used at line 1349, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1349, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_RETR" does not end with "return" at line 1349, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_STOR' declared but not used at line 1350, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1350, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_STOR" does not end with "return" at line 1350, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_STOU' declared but not used at line 1351, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1351, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_STOU" does not end with "return" at line 1351, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1352, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_RNFR" does not end with "return" at line 1352, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1353, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_REST" does not end with "return" at line 1353, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1354, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_PASS" does not end with "return" at line 1354, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1355, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_ACCT" does not end with "return" at line 1355, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1356, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_AUTH" does not end with "return" at line 1356, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 1359, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_USER" does not end with "return" at line 1359, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_SMNT' declared but not used at line 1371, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1371, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_SMNT" does not end with "return" at line 1371, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_MODE' declared but not used at line 1372, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1372, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_MODE" does not end with "return" at line 1372, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_SYST' declared but not used at line 1373, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1373, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_SYST" does not end with "return" at line 1373, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_STRU' declared but not used at line 1374, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1374, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_STRU" does not end with "return" at line 1374, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_REIN' declared but not used at line 1375, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 1375, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_REIN" does not end with "return" at line 1375, column 1. See page 197 of PBP. (Severity: 4)
# Multiple "package" declarations at line 1380, column 3. Limit to one per file. (Severity: 4)
# Subroutine "add_session" does not end with "return" at line 1382, column 3. See page 197 of PBP. (Severity: 4)
# Subroutine "DESTROY" does not end with "return" at line 1391, column 3. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/NNTP.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/NNTP.pm":
# Subroutine "can_ssl" does not end with "return" at line 44, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "can_inet6" does not end with "return" at line 45, column 1. See page 197 of PBP. (Severity: 4)
# @ISA used instead of "use base" at line 47, column 5. See page 360 of PBP. (Severity: 3)
# Subroutine "new" with high complexity score (30) at line 50, column 1. Consider refactoring. (Severity: 3)
# Always unpack @_ first at line 50, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "new" does not end with "return" at line 50, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 75, column 40. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 84, column 5. See page 283 of PBP. (Severity: 3)
# Subroutine "host" does not end with "return" at line 137, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "debug_text" does not end with "return" at line 143, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 148, column 56. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 149, column 18. See page 236 of PBP. (Severity: 3)
# Subroutine "postok" does not end with "return" at line 158, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "starttls" does not end with "return" at line 165, column 1. See page 197 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 167, column 17. See page 283 of PBP. (Severity: 3)
# Always unpack @_ first at line 174, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "article" does not end with "return" at line 174, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 175, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 187, column 1. See page 178 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 188, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 196, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "authinfo" does not end with "return" at line 196, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 205, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "authinfo_simple" does not end with "return" at line 205, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 214, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "body" does not end with "return" at line 214, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 215, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 227, column 1. See page 178 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 228, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 235, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "head" does not end with "return" at line 235, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 236, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 248, column 1. See page 178 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 249, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 256, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "nntpstat" does not end with "return" at line 256, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 257, column 3. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 260, column 41. See page 236 of PBP. (Severity: 3)
# Subroutine "group" does not end with "return" at line 266, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 267, column 3. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 280, column 57. See page 236 of PBP. (Severity: 3)
# Ambiguously named variable "last" at line 282, column 3. See page 48 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 286, column 18. See page 236 of PBP. (Severity: 3)
# Subroutine "help" does not end with "return" at line 296, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 306, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "ihave" does not end with "return" at line 306, column 1. See page 197 of PBP. (Severity: 4)
# Ambiguously named subroutine "last" at line 317, column 1. See page 48 of PBP. (Severity: 3)
# Subroutine name is a homonym for builtin function last at line 317, column 1. See page 177 of PBP. (Severity: 4)
# Subroutine "last" does not end with "return" at line 317, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 321, column 37. See page 236 of PBP. (Severity: 3)
# Subroutine "list" does not end with "return" at line 327, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "newgroups" does not end with "return" at line 337, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 352, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "newnews" does not end with "return" at line 352, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 353, column 3. See page 70 of PBP. (Severity: 4)
# Subroutine name is a homonym for builtin function next at line 373, column 1. See page 177 of PBP. (Severity: 4)
# Subroutine "next" does not end with "return" at line 373, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 377, column 37. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 383, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "post" does not end with "return" at line 383, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "quit" does not end with "return" at line 400, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "slave" does not end with "return" at line 409, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 421, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "active" does not end with "return" at line 421, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 422, column 3. See page 70 of PBP. (Severity: 4)
# Subroutine "active_times" does not end with "return" at line 431, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "distributions" does not end with "return" at line 441, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "distribution_patterns" does not end with "return" at line 451, column 1. See page 197 of PBP. (Severity: 4)
# "local" variable not initialized at line 456, column 3. See page 78 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 461, column 15. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 461, column 44. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 466, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "newsgroups" does not end with "return" at line 466, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 467, column 3. See page 70 of PBP. (Severity: 4)
# Subroutine "overview_fmt" does not end with "return" at line 476, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "subscriptions" does not end with "return" at line 486, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 496, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "listgroup" does not end with "return" at line 496, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 497, column 3. See page 70 of PBP. (Severity: 4)
# Subroutine "reader" does not end with "return" at line 506, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 514, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "xgtitle" does not end with "return" at line 514, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 515, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 524, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "xhdr" does not end with "return" at line 524, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 525, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 536, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "xover" does not end with "return" at line 536, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 537, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 547, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "xpat" does not end with "return" at line 547, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 548, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 563, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "xpath" does not end with "return" at line 563, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 571, column 28. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 572, column 17. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 578, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "xrover" does not end with "return" at line 578, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 579, column 3. See page 70 of PBP. (Severity: 4)
# Subroutine "date" does not end with "return" at line 589, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 594, column 26. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 605, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_msg_arg" does not end with "return" at line 605, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_timestr" does not end with "return" at line 634, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_grouplist" does not end with "return" at line 643, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 651, column 19. See page 236 of PBP. (Severity: 3)
# Subroutine "_fieldlist" does not end with "return" at line 659, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 667, column 19. See page 236 of PBP. (Severity: 3)
# Subroutine "_articlelist" does not end with "return" at line 676, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_description" does not end with "return" at line 687, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 698, column 17. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 710, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_ARTICLE" does not end with "return" at line 710, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 711, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_AUTHINFO" does not end with "return" at line 711, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 712, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_BODY" does not end with "return" at line 712, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_DATE" does not end with "return" at line 713, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 714, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_GROUP" does not end with "return" at line 714, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 715, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_HEAD" does not end with "return" at line 715, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 716, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_HELP" does not end with "return" at line 716, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 717, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_IHAVE" does not end with "return" at line 717, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_LAST" does not end with "return" at line 718, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 719, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_LIST" does not end with "return" at line 719, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 720, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_LISTGROUP" does not end with "return" at line 720, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 721, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_NEWGROUPS" does not end with "return" at line 721, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 722, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_NEWNEWS" does not end with "return" at line 722, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_NEXT" does not end with "return" at line 723, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 724, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_POST" does not end with "return" at line 724, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 725, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_QUIT" does not end with "return" at line 725, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 726, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_SLAVE" does not end with "return" at line 726, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_STARTTLS" does not end with "return" at line 727, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 728, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_STAT" does not end with "return" at line 728, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 729, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_MODE" does not end with "return" at line 729, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 730, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_XGTITLE" does not end with "return" at line 730, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 731, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_XHDR" does not end with "return" at line 731, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 732, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_XPAT" does not end with "return" at line 732, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 733, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_XPATH" does not end with "return" at line 733, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 734, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_XOVER" does not end with "return" at line 734, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 735, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_XROVER" does not end with "return" at line 735, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_XTHREAD' declared but not used at line 736, column 1. Eliminate dead code. (Severity: 3)
# Subroutine "_XTHREAD" does not end with "return" at line 736, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_XSEARCH' declared but not used at line 737, column 1. Eliminate dead code. (Severity: 3)
# Subroutine "_XSEARCH" does not end with "return" at line 737, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_XINDEX' declared but not used at line 738, column 1. Eliminate dead code. (Severity: 3)
# Subroutine "_XINDEX" does not end with "return" at line 738, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "DESTROY" does not end with "return" at line 745, column 1. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/Netrc.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/Netrc.pm":
# Subroutine "_readrc" with high complexity score (36) at line 26, column 1. Consider refactoring. (Severity: 3)
# Subroutine "_readrc" does not end with "return" at line 26, column 1. See page 197 of PBP. (Severity: 4)
# Backtick operator used at line 31, column 27. Use IPC::Open3 instead. (Severity: 3)
# Regular expression without "/x" flag at line 33, column 23. See page 236 of PBP. (Severity: 3)
# Mismatched operator at line 40, column 18. Numeric/string operators and operands should match. (Severity: 3)
# Mismatched operator at line 43, column 21. Numeric/string operators and operands should match. (Severity: 3)
# "local" variable not initialized at line 53, column 3. See page 78 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 61, column 15. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 81, column 24. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 88, column 7. See page 236 of PBP. (Severity: 3)
# Only use a capturing group if you plan to use the captured value at line 91, column 24. See page 252 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 91, column 24. See page 236 of PBP. (Severity: 3)
# Reused variable name in lexical scope: $tok at line 92, column 10. Invent unique variable names. (Severity: 3)
# Regular expression without "/x" flag at line 92, column 27. See page 236 of PBP. (Severity: 3)
# Found ">" in condition for an "unless" at line 107, column 11. See page 99 of PBP. (Severity: 3)
# Reused variable name in lexical scope: $host at line 112, column 11. Invent unique variable names. (Severity: 3)
# Regular expression without "/x" flag at line 119, column 24. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 124, column 21. See page 236 of PBP. (Severity: 3)
# Capture variable used outside conditional at line 125, column 19. See page 253 of PBP. (Severity: 3)
# Subroutine "login" does not end with "return" at line 169, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "account" does not end with "return" at line 178, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "password" does not end with "return" at line 187, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "lpa" does not end with "return" at line 196, column 1. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/POP3.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/POP3.pm":
# Subroutine "can_ssl" does not end with "return" at line 43, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "can_inet6" does not end with "return" at line 44, column 1. See page 197 of PBP. (Severity: 4)
# @ISA used instead of "use base" at line 46, column 5. See page 360 of PBP. (Severity: 3)
# Always unpack @_ first at line 48, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "new" does not end with "return" at line 48, column 1. See page 197 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 66, column 5. See page 283 of PBP. (Severity: 3)
# Subroutine "host" does not end with "return" at line 109, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 120, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "debug_text" does not end with "return" at line 120, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 120, column 27. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 123, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "login" does not end with "return" at line 123, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 124, column 3. See page 70 of PBP. (Severity: 4)
# Always unpack @_ first at line 135, column 1. See page 178 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 137, column 17. See page 283 of PBP. (Severity: 3)
# Always unpack @_ first at line 146, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "apop" does not end with "return" at line 146, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 147, column 3. See page 70 of PBP. (Severity: 4)
# "local" variable not initialized at line 152, column 14. See page 78 of PBP. (Severity: 3)
# "local" variable not initialized at line 155, column 17. See page 78 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 164, column 54. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 179, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "user" does not end with "return" at line 179, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 185, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "pass" does not end with "return" at line 185, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine name is a homonym for builtin function reset at line 197, column 1. See page 177 of PBP. (Severity: 4)
# Subroutine "reset" does not end with "return" at line 197, column 1. See page 197 of PBP. (Severity: 4)
# "local" variable not initialized at line 206, column 5. See page 78 of PBP. (Severity: 3)
# Ambiguously named subroutine "last" at line 214, column 1. See page 48 of PBP. (Severity: 3)
# Subroutine name is a homonym for builtin function last at line 214, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 214, column 1. See page 178 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 218, column 46. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 224, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "top" does not end with "return" at line 224, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 225, column 3. See page 70 of PBP. (Severity: 4)
# Subroutine "popstat" does not end with "return" at line 235, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 240, column 42. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 246, column 1. See page 178 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 247, column 3. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 254, column 21. See page 236 of PBP. (Severity: 3)
# Capture variable used outside conditional at line 255, column 12. See page 253 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 261, column 21. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 267, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "get" does not end with "return" at line 267, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine name is a homonym for builtin function delete at line 287, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 287, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "delete" does not end with "return" at line 287, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 295, column 1. See page 178 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 296, column 3. See page 70 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 303, column 30. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 310, column 32. See page 236 of PBP. (Severity: 3)
# Always unpack @_ first at line 318, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "ping" does not end with "return" at line 318, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 322, column 54. See page 236 of PBP. (Severity: 3)
# Subroutine "_lookup_credentials" does not end with "return" at line 328, column 1. See page 197 of PBP. (Severity: 4)
# "local" variable not initialized at line 333, column 25. See page 78 of PBP. (Severity: 3)
# Subroutine "_get_mailbox_count" does not end with "return" at line 349, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 352, column 22. See page 236 of PBP. (Severity: 3)
# Capture variable used outside conditional at line 352, column 45. See page 253 of PBP. (Severity: 3)
# Subroutine "_STAT" does not end with "return" at line 358, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 359, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_LIST" does not end with "return" at line 359, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 360, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_RETR" does not end with "return" at line 360, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 361, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_DELE" does not end with "return" at line 361, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_NOOP' declared but not used at line 362, column 1. Eliminate dead code. (Severity: 3)
# Subroutine "_NOOP" does not end with "return" at line 362, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_RSET" does not end with "return" at line 363, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_QUIT" does not end with "return" at line 364, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 365, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_TOP" does not end with "return" at line 365, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 366, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_UIDL" does not end with "return" at line 366, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 367, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_USER" does not end with "return" at line 367, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 368, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_PASS" does not end with "return" at line 368, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 369, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_APOP" does not end with "return" at line 369, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 370, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_PING" does not end with "return" at line 370, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_RPOP' declared but not used at line 371, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 371, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_RPOP" does not end with "return" at line 371, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_LAST" does not end with "return" at line 372, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_CAPA" does not end with "return" at line 373, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_STLS" does not end with "return" at line 374, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "quit" does not end with "return" at line 377, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "DESTROY" does not end with "return" at line 385, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "response" does not end with "return" at line 399, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 407, column 15. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 410, column 18. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 414, column 13. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 429, column 51. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 434, column 42. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 441, column 44. See page 236 of PBP. (Severity: 3)
# Subroutine "capabilities" does not end with "return" at line 449, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "auth" does not end with "return" at line 456, column 1. See page 197 of PBP. (Severity: 4)
# Comma used to separate statements at line 459, column 3. See pages 68,71 of PBP. (Severity: 4)
# UNIVERSAL::isa should not be used as a function at line 469, column 26. Use eval{$obj->isa($pkg)} instead. (Severity: 3)
# Regular expression without "/x" flag at line 472, column 27. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 476, column 29. See page 236 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 495, column 5. See page 283 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 508, column 26. See page 236 of PBP. (Severity: 3)
# Reused variable name in lexical scope: $token at line 548, column 5. Invent unique variable names. (Severity: 3)
# Multiple "package" declarations at line 573, column 3. Limit to one per file. (Severity: 4)
# Reused variable name in lexical scope: @ISA at line 574, column 3. Invent unique variable names. (Severity: 3)
# @ISA used instead of "use base" at line 574, column 7. See page 360 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 575, column 18. See page 283 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 578, column 26. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 580, column 4. See page 236 of PBP. (Severity: 3)
# Magic variable "$@" should be assigned as "local" at line 583, column 8. See pages 81,82 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/SMTP.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/SMTP.pm":
# Subroutine "can_ssl" does not end with "return" at line 44, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "can_inet6" does not end with "return" at line 45, column 1. See page 197 of PBP. (Severity: 4)
# @ISA used instead of "use base" at line 47, column 5. See page 360 of PBP. (Severity: 3)
# Always unpack @_ first at line 49, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "new" does not end with "return" at line 49, column 1. See page 197 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 64, column 5. See page 283 of PBP. (Severity: 3)
# Magic variable "$@" should be assigned as "local" at line 101, column 8. See pages 81,82 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 109, column 52. See page 236 of PBP. (Severity: 3)
# Magic variable "$@" should be assigned as "local" at line 114, column 8. See pages 81,82 of PBP. (Severity: 4)
# Subroutine "host" does not end with "return" at line 122, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 146, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "etrn" does not end with "return" at line 146, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "auth" does not end with "return" at line 153, column 1. See page 197 of PBP. (Severity: 4)
# Comma used to separate statements at line 156, column 3. See pages 68,71 of PBP. (Severity: 4)
# UNIVERSAL::isa should not be used as a function at line 166, column 26. Use eval{$obj->isa($pkg)} instead. (Severity: 3)
# "die" used instead of "croak" at line 174, column 5. See page 283 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 194, column 22. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 195, column 34. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 238, column 19. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 249, column 14. See page 236 of PBP. (Severity: 3)
# Capture variable used outside conditional at line 250, column 11. See page 253 of PBP. (Severity: 3)
# Always unpack @_ first at line 253, column 1. See page 178 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 255, column 17. See page 283 of PBP. (Severity: 3)
# Always unpack @_ first at line 267, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_addr" does not end with "return" at line 278, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 284, column 27. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 287, column 27. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 288, column 14. See page 236 of PBP. (Severity: 3)
# Subroutine "mail" with high complexity score (40) at line 295, column 1. Consider refactoring. (Severity: 3)
# Always unpack @_ first at line 295, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "mail" does not end with "return" at line 295, column 1. See page 197 of PBP. (Severity: 4)
# "$k" is declared but not used at line 302, column 5. Unused variables clutter code and make it harder to read. (Severity: 3)
# Regular expression without "/x" flag at line 362, column 17. See page 236 of PBP. (Severity: 3)
# Subroutine name is a homonym for builtin function send at line 415, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 415, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "send" does not end with "return" at line 415, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 416, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "send_or_mail" does not end with "return" at line 416, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 417, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "send_and_mail" does not end with "return" at line 417, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine name is a homonym for builtin function reset at line 420, column 1. See page 177 of PBP. (Severity: 4)
# Subroutine "reset" does not end with "return" at line 420, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 430, column 1. See page 178 of PBP. (Severity: 4)
# Always unpack @_ first at line 490, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "data" does not end with "return" at line 490, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "bdat" does not end with "return" at line 506, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "bdatlast" does not end with "return" at line 522, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 545, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "expand" does not end with "return" at line 545, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 554, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "verify" does not end with "return" at line 554, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 557, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "help" does not end with "return" at line 557, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "quit" does not end with "return" at line 566, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 584, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_EHLO" does not end with "return" at line 584, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 585, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_HELO" does not end with "return" at line 585, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 586, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_MAIL" does not end with "return" at line 586, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 587, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_RCPT" does not end with "return" at line 587, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 588, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_SEND" does not end with "return" at line 588, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 589, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_SAML" does not end with "return" at line 589, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 590, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_SOML" does not end with "return" at line 590, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 591, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_VRFY" does not end with "return" at line 591, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 592, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_EXPN" does not end with "return" at line 592, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 593, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_HELP" does not end with "return" at line 593, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_RSET" does not end with "return" at line 594, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_NOOP' declared but not used at line 595, column 1. Eliminate dead code. (Severity: 3)
# Subroutine "_NOOP" does not end with "return" at line 595, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_QUIT" does not end with "return" at line 596, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_DATA" does not end with "return" at line 597, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 598, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_BDAT" does not end with "return" at line 598, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_TURN' declared but not used at line 599, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 599, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_TURN" does not end with "return" at line 599, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 600, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_ETRN" does not end with "return" at line 600, column 1. See page 197 of PBP. (Severity: 4)
# Private subroutine/method '_AUTH' declared but not used at line 601, column 1. Eliminate dead code. (Severity: 3)
# Always unpack @_ first at line 601, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "_AUTH" does not end with "return" at line 601, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_STARTTLS" does not end with "return" at line 602, column 1. See page 197 of PBP. (Severity: 4)
# Multiple "package" declarations at line 606, column 3. Limit to one per file. (Severity: 4)
# Reused variable name in lexical scope: @ISA at line 607, column 3. Invent unique variable names. (Severity: 3)
# @ISA used instead of "use base" at line 607, column 7. See page 360 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 608, column 18. See page 283 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 611, column 26. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 613, column 4. See page 236 of PBP. (Severity: 3)
# Magic variable "$@" should be assigned as "local" at line 616, column 8. See pages 81,82 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/Time.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/Time.pm":
# @ISA used instead of "use base" at line 23, column 5. See page 360 of PBP. (Severity: 3)
# Subroutine "_socket" does not end with "return" at line 30, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 64, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "inet_time" does not end with "return" at line 64, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 94, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "inet_daytime" does not end with "return" at line 94, column 1. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/external/ftp-ssl.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/external/ftp-ssl.t":
# "die" used instead of "croak" at line 62, column 8. See page 283 of PBP. (Severity: 3)
# "die" used instead of "croak" at line 79, column 8. See page 283 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/external/pop3-ssl.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/external/pop3-ssl.t":
# Warnings disabled at line 16, column 1. See page 431 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 19, column 8. See page 283 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "t/external/smtp-ssl.t"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "t/external/smtp-ssl.t":
# Warnings disabled at line 16, column 1. See page 431 of PBP. (Severity: 4)
# "die" used instead of "croak" at line 19, column 8. See page 283 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/FTP/A.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/FTP/A.pm":
# @ISA used instead of "use base" at line 15, column 5. See page 360 of PBP. (Severity: 3)
# Package variable declared or used at line 18, column 1. See pages 73,75 of PBP. (Severity: 3)
# Subroutine name is a homonym for builtin function read at line 20, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 20, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "read" does not end with "return" at line 20, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 55, column 19. See page 236 of PBP. (Severity: 3)
# Lvalue form of "substr" used at line 70, column 31. See page 165 of PBP. (Severity: 3)
# Subroutine name is a homonym for builtin function write at line 76, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 76, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "write" does not end with "return" at line 76, column 1. See page 197 of PBP. (Severity: 4)
# Regular expression without "/x" flag at line 84, column 11. See page 236 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 85, column 11. See page 236 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/FTP/E.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/FTP/E.pm":
# @ISA used instead of "use base" at line 10, column 5. See page 360 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/FTP/I.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/FTP/I.pm":
# @ISA used instead of "use base" at line 15, column 5. See page 360 of PBP. (Severity: 3)
# Package variable declared or used at line 18, column 1. See pages 73,75 of PBP. (Severity: 3)
# Subroutine name is a homonym for builtin function read at line 20, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 20, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "read" does not end with "return" at line 20, column 1. See page 197 of PBP. (Severity: 4)
# Mixed high and low-precedence booleans at line 29, column 7. See page 70 of PBP. (Severity: 4)
# Lvalue form of "substr" used at line 46, column 28. See page 165 of PBP. (Severity: 3)
# Subroutine name is a homonym for builtin function write at line 54, column 1. See page 177 of PBP. (Severity: 4)
# Always unpack @_ first at line 54, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "write" does not end with "return" at line 54, column 1. See page 197 of PBP. (Severity: 4)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/FTP/L.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/FTP/L.pm":
# @ISA used instead of "use base" at line 10, column 5. See page 360 of PBP. (Severity: 3)
Policy "Perl::Critic::Policy::Modules::ProhibitModuleShebang" is not installed.
# Failed test 'Test::Perl::Critic for "lib/Net/FTP/dataconn.pm"'
# at /Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Net/FTP/dataconn.pm":
# "die" used instead of "croak" at line 18, column 23. See page 283 of PBP. (Severity: 3)
# @ISA used instead of "use base" at line 19, column 5. See page 360 of PBP. (Severity: 3)
# Subroutine "reading" does not end with "return" at line 21, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "abort" does not end with "return" at line 27, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "_close" does not end with "return" at line 53, column 1. See page 197 of PBP. (Severity: 4)
# Ambiguously named subroutine "close" at line 66, column 1. See page 48 of PBP. (Severity: 3)
# Subroutine name is a homonym for builtin function close at line 66, column 1. See page 177 of PBP. (Severity: 4)
# Subroutine "close" does not end with "return" at line 66, column 1. See page 197 of PBP. (Severity: 4)
# Return value of eval not tested at line 72, column 5. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
# "local" variable not initialized at line 72, column 12. See page 78 of PBP. (Severity: 3)
# Regular expression without "/x" flag at line 81, column 25. See page 236 of PBP. (Severity: 3)
# Subroutine "_select" does not end with "return" at line 88, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 109, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "can_read" does not end with "return" at line 109, column 1. See page 197 of PBP. (Severity: 4)
# Always unpack @_ first at line 114, column 1. See page 178 of PBP. (Severity: 4)
# Subroutine "can_write" does not end with "return" at line 114, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "cmd" does not end with "return" at line 119, column 1. See page 197 of PBP. (Severity: 4)
# Subroutine "bytes_read" does not end with "return" at line 126, column 1. See page 197 of PBP. (Severity: 4)
# Looks like you failed 35 tests of 44.
t/critic.t ........
Dubious, test returned 35 (wstat 8960, 0x2300)
Failed 35/44 subtests
t/datasend.t ...... ok
t/ftp.t ........... skipped: no ftp_testhost defined in config
t/hostname.t ...... ok
t/netrc.t ......... ok
t/nntp.t .......... skipped: (no reason given)
t/nntp_ipv6.t ..... skipped: no IPv6 support found in Net::NNTP
# created Net::NNTP object
# NNTP dialog done
# created Net::NNTP object
# NNTP dialog done
t/nntp_ssl.t ...... ok
t/pod.t ........... ok
t/pod_coverage.t .. ok
t/pop3_ipv6.t ..... skipped: no IPv6 support found in Net::POP3
# created Net::POP3 object
# POP3 dialog done
# created Net::POP3 object
# POP3 dialog done
t/pop3_ssl.t ...... ok
t/require.t ....... ok
t/smtp.t .......... skipped: (no reason given)
t/smtp_ipv6.t ..... skipped: no IPv6 support found in Net::SMTP
# created Net::SMTP object
# SMTP dialog done
# created Net::SMTP object
# SMTP dialog done
t/smtp_ssl.t ...... ok
t/time.t .......... ok
Test Summary Report
-------------------
t/critic.t (Wstat: 8960 Tests: 44 Failed: 35)
Failed tests: 1-5, 7, 9, 11, 14-18, 21-22, 25-44
Non-zero exit status: 35
Files=18, Tests=184, 25 wallclock secs ( 0.11 usr 0.07 sys + 23.82 cusr 0.51 csys = 24.51 CPU)
Result: FAIL
------------------------------
PREREQUISITES
------------------------------
Prerequisite modules loaded:
No requirements found
------------------------------
ENVIRONMENT AND OTHER CONTEXT
------------------------------
Environment variables:
LANG = en_US.UTF-8
LC_ALL = en_US.UTF-8
LC_CTYPE = en_US.UTF-8
PATH = /Users/stas/perl5/perlbrew/bin:/Users/stas/perl5/perlbrew/perls/perl-5.8.9/bin:/Users/stas/perl5/perlbrew/bin:/Users/stas/perl5/perlbrew/perls/perl-5.20.1/bin:/Users/stas/.vim/bin:/Users/stas/bin:/Users/stas/node_modules/.bin:/opt/local/Library/Frameworks/Python.framework/Versions/2.7/bin:/opt/local/lib/postgresql92/bin:/opt/local/bin:/opt/local/sbin:/opt/local/libexec/ccache:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/opt/X11/bin:/Users/stas/.vim/bin:/Users/stas/bin:/Users/stas/node_modules/.bin:/opt/local/Library/Frameworks/Python.framework/Versions/2.7/bin:/opt/local/lib/postgresql92/bin:/opt/local/bin:/opt/local/sbin:/opt/local/libexec/ccache
PERL5LIB =
PERLBREW_BASHRC_VERSION = 0.71
PERLBREW_HOME = /Users/stas/.perlbrew
PERLBREW_LIB =
PERLBREW_MANPATH = /Users/stas/perl5/perlbrew/perls/perl-5.8.9/man
PERLBREW_PATH = /Users/stas/perl5/perlbrew/bin:/Users/stas/perl5/perlbrew/perls/perl-5.8.9/bin
PERLBREW_PERL = perl-5.8.9
PERLBREW_ROOT = /Users/stas/perl5/perlbrew
PERLBREW_VERSION = 0.71
PERL_LOCAL_LIB_ROOT =
PERL_MM_USE_DEFAULT = 1
SHELL = /opt/local/bin/zsh
TERM = screen
TMPDIR = /var/folders/k7/cj2hxbn162362g2150r7t9480000gn/T/
Perl special variables (and OS-specific diagnostics, for MSWin32):
EGID = 20 20 508 12 61 79 80 81 98 398 399 33 100 204
EUID = 501
EXECUTABLE_NAME = /Users/stas/perl5/perlbrew/perls/perl-5.8.9/bin/perl
GID = 20 20 508 12 61 79 80 81 98 398 399 33 100 204
UID = 501
Perl module toolchain versions installed:
Module Have
------------------- --------
CPAN 2.05
CPAN::Meta 2.142690
Cwd 3.47
ExtUtils::CBuilder 0.280220
ExtUtils::Command 1.18
ExtUtils::Install 2.04
ExtUtils::MakeMaker 6.98
ExtUtils::Manifest 1.68
ExtUtils::ParseXS 3.24
File::Spec 3.47
JSON 2.90
JSON::PP 2.27300
Module::Build 0.4210
Module::Signature 0.73
Parse::CPAN::Meta 1.4414
Test::Harness 3.33
Test::More 1.001006
YAML 1.12
YAML::Syck 1.27
version 0.9909
--
Summary of my perl5 (revision 5 version 8 subversion 9) configuration:
Platform:
osname=darwin, osvers=13.0.0, archname=darwin-2level
uname='darwin stas-macbook 13.0.0 darwin kernel version 13.0.0: thu sep 19 22:22:27 pdt 2013; root:xnu-2422.1.72~6release_x86_64 x86_64 '
config_args='-de -Dprefix=/Users/stas/perl5/perlbrew/perls/perl-5.8.9 -Aeval:scriptdir=/Users/stas/perl5/perlbrew/perls/perl-5.8.9/bin'
hint=recommended, useposix=true, d_sigaction=define
usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef
useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
use64bitint=define use64bitall=define uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='cc', ccflags ='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -I/opt/local/include',
optimize='-O3',
cppflags='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -I/opt/local/include'
ccversion='', gccversion='4.2.1 Compatible Apple LLVM 5.0 (clang-500.2.79)', gccosandvers=''
intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries:
ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -L/usr/local/lib -L/opt/local/lib'
libpth=/usr/local/lib /opt/local/lib /usr/lib
libs=-lgdbm -ldbm -ldl -lm -lutil -lc
perllibs=-ldl -lm -lutil -lc
libc=, so=dylib, useshrplib=false, libperl=libperl.a
gnulibc_version=''
Dynamic Linking:
dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/usr/local/lib -L/opt/local/lib'
Characteristics of this binary (from libperl):
Compile-time options: PERL_MALLOC_WRAP USE_64_BIT_ALL USE_64_BIT_INT
USE_FAST_STDIO USE_LARGE_FILES USE_PERLIO
Built under darwin
Compiled at Dec 25 2013 17:36:43
%ENV:
PERL5LIB=""
PERLBREW_BASHRC_VERSION="0.71"
PERLBREW_HOME="/Users/stas/.perlbrew"
PERLBREW_LIB=""
PERLBREW_MANPATH="/Users/stas/perl5/perlbrew/perls/perl-5.8.9/man"
PERLBREW_PATH="/Users/stas/perl5/perlbrew/bin:/Users/stas/perl5/perlbrew/perls/perl-5.8.9/bin"
PERLBREW_PERL="perl-5.8.9"
PERLBREW_ROOT="/Users/stas/perl5/perlbrew"
PERLBREW_VERSION="0.71"
PERL_LOCAL_LIB_ROOT=""
PERL_MM_USE_DEFAULT="1"
@INC:
/Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/5.8.9/darwin-2level
/Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/5.8.9
/Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9/darwin-2level
/Users/stas/perl5/perlbrew/perls/perl-5.8.9/lib/site_perl/5.8.9
.